Add lspServers config to phpactor plugin#28
Closed
micahstubbs wants to merge 1 commit intoPiebald-AI:mainfrom
Closed
Add lspServers config to phpactor plugin#28micahstubbs wants to merge 1 commit intoPiebald-AI:mainfrom
micahstubbs wants to merge 1 commit intoPiebald-AI:mainfrom
Conversation
Fixes Piebald-AI#15 Claude Code reads LSP configuration from the lspServers field in marketplace.json, not from .lsp.json files in plugin directories.
Member
|
@Fkscorpion I see you've reacted to this PR; are you able to help me understand the value of it? I'm not aware of |
|
@bl-ue I honestly can't remember why I liked this PR specifically, I know I had some issues setting up the lsp plugin with phpactor but it's running for some time now... so I'm very sorry and thank you for asking before closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lspServersconfiguration to phpactor plugin entry in marketplace.jsonFixes #15
Root Cause
Claude Code reads LSP configuration from the
lspServersfield in marketplace.json, not from.lsp.jsonfiles in plugin directories.Test Plan